view
Tweet
hifi: #21458 Short Bow improvements

1) Laser/stylus become unusable
Steps to reproduce:
1) Get the bow from the marketplace
2) When you first get it, the laser/stylus works, you can drop it and use the grip or trigger to pick it up with either hand
3) Very rapidly shoot multiple arrows (I think I did around 10) in the same general direction--I didn't even bother pulling back all the way.

After doing this, I couldn't use the distance laser, stylus, or even unequip the bow. Also occurred while playing with the bow itself in sandbox.

2) Stops spawning balls and bows
Steps to reproduce:
1) Go to marketplace and add the shortbow game to your domain
2) Hit play
3) Enter Create/edit mode and move the game

The spawn points don't move with the game. For some shortbow games the balls spawn, behind the avatar shop instead of in the pit and will freely roll anywhere in the domain. Since the game itself is not a locked asset, this is probably from it getting moved after being placed the first time. However, no balls spawned and the start sign failed to appear after wave 10, so it may be losing the ability to keep track of how many balls are still present.

Fix shortbow so these things no longer happen.

Comments & Activity

  • 1 yr, 8 mnths ago

    #21458 created by themelissabrown Status set to Bidding.

  • 1 yr, 8 mnths ago

    A bid was placed on #21458

  • 1 yr, 8 mnths ago

    A bid was deleted from #21458

  • 1 yr, 7 mnths ago

    A bid was placed on #21458

  • 1 yr, 7 mnths ago

    themelissabrown accepted 300.00 from MiladNazeri on #21458 Status set to In Progress.

  • Hi @themelissabrown,

    Hope you are doing well. I wanted to briefly check in with you this morning for this job.

    I'm making good progress on the job, but I wanted to make sure this wasn't urgent, as I'd like to take more time to test my solutions and refactor a bit.

    Please let me know if it's needed by a certain time.
  • Hi @MiladNazeri - Just checking in to see how this is coming along
  • Will be connecting Milad to @pippilina for some questions regarding the model we're using and to @thoys for some coding approach help
  • hi @MiladNazeri did you get the answers you needed? Or do I need to facilitate conversations with the two people above?
  • @themelissabrown Just pushed up to my branch the latest changes, but not sure if the automation happened correctly. Please let me know if I need to push to the Hifi repo instead of my fork as the worklist instructions informed me.

    Test Plan :
    For Section 1 :
    -------------------------------------------------------------
    Re:
    1) Laser/stylus become unusable
    Steps to reproduce:
    1) Get the bow from the marketplace
    2) When you first get it, the laser/stylus works, you can drop it and use the grip or trigger to pick it up with either hand
    3) Very rapidly shoot multiple arrows (I think I did around 10) in the same general direction--I didn't even bother pulling back all the way
    -------------------------------------------------------------
    - If you are able to shoot multiple arrows as fast as you can shoot, then this problem should be fixed.

    My computer was giving me issues at first around 7-10 but the number would change depending on system resources available.

    For Section 2:
    -------------------------------------------------------------
    Re:

    2) Stops spawning balls and bows
    Steps to reproduce:
    1) Go to marketplace and add the shortbow game to your domain
    2) Hit play
    3) Enter Create/edit mode and move the game

    The spawn points don't move with the game. For some shortbow games the balls spawn, behind the avatar shop instead of in the pit and will freely roll anywhere in the domain. Since the game itself is not a locked asset, this is probably from it getting moved after being placed the first time. However, no balls spawned and the start sign failed to appear after wave 10, so it may be losing the ability to keep track of how many balls are still present.
    -------------------------------------------------------------

    - Most of this problem had to do with the randomized jump being initiated too quickly after spawning.
    - Moving the board around while playing should reset the wave and spawn positions
    - No balls should be outside of the play area
    - Lives should be tracking fine despite the wave number.
  • I'm not seeing a PR so I'm guessing you need to push to the Hifi repo. Let me know if you need any help with that process.
  • 1 yr, 6 mnths ago

    #21458 updated by themelissabrown Changes: Status set to Done.

Labels Saved!

Bids

Login to bid
Who Amount Done in ...
*name hidden*$ ***1 day